Fix panic when resources root path is not the working directory#112
Merged
oxtoacart merged 1 commit intogetlantern:masterfrom Dec 9, 2019
Merged
Fix panic when resources root path is not the working directory#112oxtoacart merged 1 commit intogetlantern:masterfrom
oxtoacart merged 1 commit intogetlantern:masterfrom
Conversation
Contributor
|
Thanks @ksubileau! |
ropog3ovomou
pushed a commit
to ropog3ovomou/systray
that referenced
this pull request
Jul 13, 2022
Fix panic when resources root path is not the working directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, Walk look for the icon in its resources root path, but systray write it to the current working directory.
The current working directory is the default root path, but it may be changed by external code (walk.Resources.SetRootDirPath()).
In this case, systray panic because walk can't find the temporary icon.
This PR fix this issue by writing the icon to the correct resources root path.
My personal use case is to set the resources root path to os.TempDir() to avoid a panic in case of the current working directory is not writable.